[PATCH] Forbid the use of registers t6, t7 and t8 if the target is MIPS NaCl.

Eric Christopher echristo at gmail.com
Tue Feb 4 13:16:13 PST 2014


  Couple of comments here.


================
Comment at: lib/Target/Mips/MipsRegisterInfo.cpp:137
@@ -136,1 +136,3 @@
 
+  // Reserved for PNaCl use
+  if (Subtarget.isTargetNaCl()) {
----------------
Comments should be complete sentences. Also, if you can, you should add what the various registers are used for so that it's documented.


http://llvm-reviews.chandlerc.com/D2694



More information about the llvm-commits mailing list