[PATCH] [RFC] Compiler-RT on ARM via CMake
Alexey Samsonov
samsonov at google.com
Fri Jan 31 04:15:28 PST 2014
LGTM
Thanks for working on this!
================
Comment at: CMakeLists.txt:215
@@ -212,3 +214,3 @@
filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH
- x86_64 i386 powerpc64)
+ x86_64 i386 powerpc64 arm)
----------------
Renato Golin wrote:
> Alexey Samsonov wrote:
> > So, do asan, lsan, profile and ubsan build successfully on ARM and pass the tests? Are you sure you want to enable building them now, when we still don't have a buildbot or decent support? If you tell that they are necessary for Clang tests, let's first fix the Clang tests so that they won't be necessary.
> They build successfully and pass the tests (apart from the three leak-detection that you should have disabled now). So, I'd rather keep them, so that other people can progress the support on ARM (and I'll be building it regularly and will get a warning if they regress).
>
> Regardless, Clang should be fixed to not automatically assume rt == asan.
OK, let's do it then. As I mentioned earlier, those three test failures were not related to leak detection, so the failures will likely remain (we may have to disable them on ARM, but that wouldn't be a big deal).
http://llvm-reviews.chandlerc.com/D2604
More information about the llvm-commits
mailing list