[PATCH] [RFC] Compiler-RT on ARM via CMake

Renato Golin renato.golin at linaro.org
Fri Jan 31 04:09:19 PST 2014



================
Comment at: CMakeLists.txt:215
@@ -212,3 +214,3 @@
 filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH
-  x86_64 i386 powerpc64)
+  x86_64 i386 powerpc64 arm)
 
----------------
Alexey Samsonov wrote:
> So, do asan, lsan, profile and ubsan build successfully on ARM and pass the tests? Are you sure you want to enable building them now, when we still don't have a buildbot or decent support? If you tell that they are necessary for Clang tests, let's first fix the Clang tests so that they won't be necessary.
They build successfully and pass the tests (apart from the three leak-detection that you should have disabled now). So, I'd rather keep them, so that other people can progress the support on ARM (and I'll be building it regularly and will get a warning if they regress).

Regardless, Clang should be fixed to not automatically assume rt == asan.

================
Comment at: lib/asan/lit_tests/Unit/lit.site.cfg.in:16
@@ -16,1 +15,3 @@
+# Make sure we're dealing with a supported architecture
+if config.host_os in ['Linux'] and config.host_arch in ['x86_64']:
   config.environment['ASAN_OPTIONS'] = 'detect_leaks=1'
----------------
Alexey Samsonov wrote:
> Thanks, I've landed this part of your CL in r200537.
Great, I'll remove it from my changes. Cheers!


http://llvm-reviews.chandlerc.com/D2604



More information about the llvm-commits mailing list