[PATCH] Bug 17310

[David Blaikie]

On Mon, Jan 27, 2014 at 10:21 AM, James Courtier-Dutton <
james.dutton at gmail.com> wrote:

> On 27 January 2014 17:24, David Blaikie <dblaikie at gmail.com> wrote:
> > Looks like this was committed (without a test case) by Craig in 200100.
> >
> > Craig - any reason it's missing a test case?
> >
> >>>
> >>> Is there any chance of getting this bug fixed?
> >>> http://llvm.org/bugs/show_bug.cgi?id=17310
> >>>
> >>> It is a very simple 2 line patch (see below).
> >>> There is also a test case in the bug report.
> >>>
>
> There is a test case in the bug report.
> It tests the disassembler callback API. Something that is not covered
> in any other tests.
> So, I cannot simply add an extra instruction to the current filecheck
> tests.
>
> I would need some guidance as to how to modify the current test I have
> written to fit with the LLVM automatic testing.
> The test I have written submits hex bytes to the disassembler, and
> then checks that the correct callbacks were called with the correct
> parameters during the disassemble/decode of the instruction.
>

We do have unit tests as well for arbitrary API-level testing (see
llvm/unittests) - though I don't know how amenable this particular API is
to unit testing. If it's moderately convenient it'd be great to add such a
test. If it requires a lot of engineering to make the API unittestable then
that burden isn't necessarily on you to do.

- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140127/5762d202/attachment.html>