[PATCH] Bug 17310

[David Blaikie]

Looks like this was committed (without a test case) by Craig in 200100.

Craig - any reason it's missing a test case?


On Mon, Jan 27, 2014 at 9:22 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Please include an appropriate regression test (FileCheck, lit, etc) along
> with the patch (& include the patch as an attachment to avoid any chance of
> it being mangled by email handling)
>
>
> On Sat, Jan 25, 2014 at 2:18 PM, James Courtier-Dutton <
> james.dutton at gmail.com> wrote:
>
>> Hi,
>>
>> Is there any chance of getting this bug fixed?
>> http://llvm.org/bugs/show_bug.cgi?id=17310
>>
>> It is a very simple 2 line patch (see below).
>> There is also a test case in the bug report.
>>
>> diff --git a/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c
>> b/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c
>> index 20e61da..0467a21 100644
>> --- a/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c
>> +++ b/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c
>> @@ -1115,6 +1115,9 @@ static int readModRM(struct InternalInstruction*
>> insn) {
>>    rm      = rmFromModRM(insn->modRM);
>>    reg     = regFromModRM(insn->modRM);
>>
>> +  if (mod == 1)
>> +    insn->displacementSize = 1;
>> +
>>    /*
>>     * This goes by insn->registerSize to pick the correct register, which
>> messes
>>     * up if we're using (say) XMM or 8-bit register operands.  That
>> gets fixed in
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140127/e6ef29b7/attachment.html>