[PATCH] ARM IAS: support .object_arch
Saleem Abdulrasool
compnerd at compnerd.org
Mon Jan 20 08:05:43 PST 2014
On Mon, Jan 20, 2014 at 12:49 AM, Renato Golin <renato.golin at linaro.org>wrote:
>
> Hi Saleem,
>
> The test directive-object_arch-2.s seems redundant, as it's using the
> same directives as directive-object_arch.s and directive-object_arch-3.s is
> already testing the parse of swapped directives. The rest looks good to me.
>
The third test is for the assembly emission, and would not actually test if
the object file contains the right value (which the second test does). So,
I dont feel that it is redundant.
cheers,
> --renato
>
> http://llvm-reviews.chandlerc.com/D2578
>
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140120/e6f25df2/attachment.html>
More information about the llvm-commits
mailing list