Hi Saleem, The test directive-object_arch-2.s seems redundant, as it's using the same directives as directive-object_arch.s and directive-object_arch-3.s is already testing the parse of swapped directives. The rest looks good to me. cheers, --renato http://llvm-reviews.chandlerc.com/D2578