[PATCH] ARM IAS: support .movsp

Logan Chien tzuhsiang.chien at gmail.com
Sun Jan 19 04:32:06 PST 2014



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1180
@@ +1179,3 @@
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
+
----------------
Renato Golin wrote:
> Do you need the same kind of asserts when emitting asm, too?
It seems that the condition "UsedFP" should be changed to "FPReg == ARM::SP"; otherwise, some test case, which you have added, might fail.


http://llvm-reviews.chandlerc.com/D2530



More information about the llvm-commits mailing list