[PATCH] ARM IAS: support .movsp

[Saleem Abdulrasool]

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1180
@@ +1179,3 @@
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
+
----------------
Logan Chien wrote:
> Renato Golin wrote:
> > Do you need the same kind of asserts when emitting asm, too?
> It seems that the condition "UsedFP" should be changed to "FPReg == ARM::SP"; otherwise, some test case, which you have added, might fail.
I like stronger assertions, duplicated in the asm case.

Logan, I think that the assertion should hold as we should be emitting diagnostics for invalid scenarios and therefore the emission should never occur.  Or am I misunderstanding the scenario where the assertion may be overly aggressive?


http://llvm-reviews.chandlerc.com/D2530