[PATCH] make msandr access tls directly
Evgeniy Stepanov
eugenis at google.com
Fri Jan 17 07:21:54 PST 2014
================
Comment at: msandr.cc:373
@@ -368,1 +372,3 @@
#else /* !MSANDR_STANDALONE_TEST */
+# ifdef MSANDR_NATIVE_EXEC
+ /* For optimized native exec, -mangle_app_seg and -private_loader are turned off,
----------------
In fact, since we control all transitions between instrumented and uninstrumented code, we can do this cleanup exactly once per transition.
This memory is only ever written non-zero values in instrumented code.
If I understand correctly, this is a correctness rather then optimization change. If so, LGTM, and the above can be addressed later.
================
Comment at: msandr.cc:420
@@ -405,1 +419,3 @@
#else /* !MSANDR_STANDALONE_TEST */
+# ifdef MSANDR_NATIVE_EXEC
+ for (int i = 0; i < NUM_TLS_PARAM; ++i) {
----------------
The same as retval_tls.
http://llvm-reviews.chandlerc.com/D2568
More information about the llvm-commits
mailing list