[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

Joerg Sonnenberger joerg at britannica.bec.de
Wed Jan 15 02:39:40 PST 2014


On Wed, Jan 15, 2014 at 10:34:00AM +0000, Renato Golin wrote:
> Hi David,
> 
> I still think this is a bit of a hack:
> 
> +  const bool AllowAtInIdentifier = getLexer().getAllowAtInIdentifier();
> +  getLexer().setAllowAtInIdentifier(true);
>    Lex();
> +  getLexer().setAllowAtInIdentifier(AllowAtInIdentifier);
> 
> But I'm not too worried about this going in, if others consent to it.

It serves the purpose and as long as the person responsible for the use
of @ as start-of-comment gets the proper amount of force applied...

Joerg



More information about the llvm-commits mailing list