[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments
Renato Golin
renato.golin at linaro.org
Wed Jan 15 02:34:00 PST 2014
Hi David,
I still think this is a bit of a hack:
+ const bool AllowAtInIdentifier = getLexer().getAllowAtInIdentifier();
+ getLexer().setAllowAtInIdentifier(true);
Lex();
+ getLexer().setAllowAtInIdentifier(AllowAtInIdentifier);
But I'm not too worried about this going in, if others consent to it.
It seems to me that the lexer should know or have a flag, but the @ symbol
for ARM is quite the hack in itself, so making that specific to the lexer
might be going the wrong way altogether.
If others agree, I think it's good to go now.
cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140115/19217c39/attachment.html>
More information about the llvm-commits
mailing list