[PATCH] PR17647: ARM IAS needs Alias for MUL/MLA/SMLAL/UMLAL

Renato Golin renato.golin at linaro.org
Tue Jan 14 12:09:47 PST 2014


Thanks! LGTM.

--renato


On 14 January 2014 19:49, <zhaoshiz at codeaurora.org> wrote:

> Hi Renato,
>
> The MLA definitions use register class GPR rathan GPRnopc.
> I attached a patch that fixes both MLA defs and the alias.
>
> Thanks,
> Zhaoshi
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by
> The Linux Foundation
>
> > Hi,
> >
> > +def : InstAlias<"mla${s}${p} $Rd, $Rn, $Rm, $Ra",
> > +            (MLA GPR:$Rd, GPR:$Rn, GPR:$Rm, GPR:$Ra, pred:$p,
> > cc_out:$s)>,
> > +         Requires<[IsARM, NoV6]>;
> >
> > R15 can't be used on those as well, would be better to use GPRnopc class.
> >
> > The rest seems fine, thanks!
> > --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140114/2636e8f8/attachment.html>


More information about the llvm-commits mailing list