<div dir="ltr">Thanks! LGTM.<div><br></div><div>--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 14 January 2014 19:49, <span dir="ltr"><<a href="mailto:zhaoshiz@codeaurora.org" target="_blank">zhaoshiz@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Renato,<br>
<br>
The MLA definitions use register class GPR rathan GPRnopc.<br>
I attached a patch that fixes both MLA defs and the alias.<br>
<div class="im HOEnZb"><br>
Thanks,<br>
Zhaoshi<br>
<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by<br>
The Linux Foundation<br>
<br>
</div><div class="HOEnZb"><div class="h5">> Hi,<br>
><br>
> +def : InstAlias<"mla${s}${p} $Rd, $Rn, $Rm, $Ra",<br>
> + (MLA GPR:$Rd, GPR:$Rn, GPR:$Rm, GPR:$Ra, pred:$p,<br>
> cc_out:$s)>,<br>
> + Requires<[IsARM, NoV6]>;<br>
><br>
> R15 can't be used on those as well, would be better to use GPRnopc class.<br>
><br>
> The rest seems fine, thanks!<br>
> --renato</div></div></blockquote></div><br></div>