[PATCH] Fix Remote MCJIT protocol

Andy Kaylor andrew.kaylor at intel.com
Tue Jan 14 10:51:25 PST 2014


  This looks great.  Thanks for the work!

  I have just the one minor comment about LLIMessageStatus size.


================
Comment at: tools/lli/ChildTarget/ChildTarget.cpp:241
@@ +240,3 @@
+  // Write the result.
+  rc = WriteBytes(&Status, 4);
+  assert(rc == 4);
----------------
It doesn't look to me like the size of LLIMessageStatus is guaranteed to be 4.  Maybe you can specify an explicit type for the enum.


http://llvm-reviews.chandlerc.com/D2527



More information about the llvm-commits mailing list