[PATCH] Fix Remote MCJIT protocol

[Renato Golin]

Tim, Andrew, any more comments?

Can I commit?


On 10 January 2014 00:00, Renato Golin <renato.golin at linaro.org> wrote:

> On 9 January 2014 19:29, Alp Toker <alp at nuanti.com> wrote:
>
>> Drive-by comment: Can you move all the rc asserts into a single check
>> within ReadBytes()?
>>
>> They seem to check the same thing -- that the requested number of bytes
>> was actually read.
>
>
> Just realise I can't do that, because handleLoadSection doesn't assert on
> bad message, but return LLI_Status_IncompleteMsg to the caller, as I think
> it should, since in that case, assert would be too hard failure, the caller
> might want to try again in the future.
>
> Since that file is going to die soon, I'd rather leave hard choices for a
> different commit.
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140113/7c241a5c/attachment.html>