[PATCH] Add support for parsing ARM symbol variants on ELF targets
Tim Northover
t.p.northover at gmail.com
Wed Dec 4 00:49:17 PST 2013
Hi David,
> I've attached a patch that removes most of the VK_ARM_* types along with
> parsing the variants correctly for ARM.
Thanks! I love seeing refactoring like this. I've got one comment:
+ if (Lexer.isNot(AsmToken::RParen)) {
+ return Error(Lexer.getTok().getLoc(), "unexpected token in variant");
I think this error message could be more helpful if it mentions that
we expect a closing paren. I'd be happy for you to fix that and commit
without posting another patch for review -- I'll take a look at the
commit.
Cheers.
Tim.
More information about the llvm-commits
mailing list