[PATCH] Add support for parsing ARM symbol variants on ELF targets

[David Peixotto]

> > There's a FIXME in include/llvm/MC/MCExpr.h saying we'd like to move
> > towards eliminating the VK_ARM_* types (where possible, obviously
> > TARGET1 and so on are ARM-specific and would remain).
> >
> > This patch seems like it's most of the way there: the
> > UseParenForSymbolVariant is just the extra bit of information that's
> > needed to eliminate the distinction. Did you investigate what would be
> > needed to perform that merge at the same time?
> 
> I did notice that FIXME. I did not investigate if this patch provides the
> necessary mechanism to remove the arm specific VK types, mostly out of
> ignorance of why that distinction was there to begin with. It sounds like
> you are suggesting that the distinction was fairly superficial and mostly
> related to printing them correctly. If that's the case then I think we
> should be able to remove most of the arm-specific variants.
> 
> Let me look into it.

I've attached a patch that removes most of the VK_ARM_* types along with
parsing the variants correctly for ARM. The only one I was unsure about was
VK_ARM_NONE. I left it in because it looked like it has a different meaning
that the VK_NONE type.

Please help to review this patch.

Thanks,
David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-parsing-ARM-symbol-variants-on-ELF-t.patch
Type: application/octet-stream
Size: 23071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131203/7722aa08/attachment.obj>