[PATCH] ClamAV output

[Daniel Dunbar]

Hi Renato,

I think this workaround is fine, go ahead with it.

On Monday, November 25, 2013, Renato Golin wrote:

> Hi Folks,
>
> I have another Chromebook buildbot internally which I want to put up, but
> ClamAV is failing on it for the reasons it fails on some systems and not
> others. Not to mention the unnecessary worry it generates during releases.
>
> I have looked for potential sources of problems and have not found any
> (compiler, OS version, libraries, hardware type, build system used), and
> the source code is not particularly simple to understand why the order
> changes, so I'm out of ideas.
>
> If anyone care that much for this output order, could I ask him/her to
> look at it, or accept the workaround which is the patch attached to the
> original email? Nikola and Arnaud tested on their failing system and the
> test now reports as passing. I did so, too on my failing systems and they,
> too, report passing.
>
> thanks,
> --renato
>
>
> On 20 November 2013 15:38, Renato Golin <renato.golin at linaro.org> wrote:
>
>> Hi Daniel,
>>
>> Again, everyone running ClamAV has trouble with the output. I did some
>> investigations in the past, but couldn't find the answer on why that
>> message is out of order, but I remember discussing with the author of the
>> code that our version is too old and may not be worth fixing, but replacing
>> with a newer version.
>>
>> So, while I'm aware that the proposed fix (attached) is not the best, I
>> don't think we'd gain much from decoding an old code base, and would spend
>> better time getting the new version with a better output to make sure the
>> test is actually ok.
>>
>> Furthermore, since this test is failing on half of the machines out
>> there, and nobody care to fix, I'm assuming nobody care much for this piece
>> of output.
>>
>> My silly patch works on both types of machines: those that were passing
>> (for some magical reason) and those that weren't (for another magical
>> reason). ;)
>>
>> Would be good to have that for the release 3.4 testing.
>>
>> cheers,
>> --renato
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131125/65f4cfff/attachment.html>