[PATCH] Implement a bunch of custom glibc wrappers & corresponding tests.

Peter Collingbourne peter at pcc.me.uk
Fri Nov 22 13:30:00 PST 2013



================
Comment at: lib/dfsan/scripts/check_custom_wrappers.sh:18
@@ +17,3 @@
+
+diff \
+  <(grep "^fun:.*=custom" ${DFSAN_ABI_LIST} | grep -v "dfsan_get_label" \
----------------
Please use diff -u. I find non-unified diffs hard to read.

================
Comment at: lib/dfsan/scripts/check_custom_wrappers.sh:35
@@ +34,3 @@
+    | sort) \
+  <(grep "^\\s*test_.*();" ${DFSAN_CUSTOM_TESTS} \
+    | sed "s/.*test_\(.*\)();/\1/" \
----------------
I think the problem is with this grep command. I asked the owner of the buildbot to try a few things and it seems like adding the -E flag to grep should make this work. (The buildbot runs a newer version of GNU grep which seemingly doesn't understand \s in BREs.)


http://llvm-reviews.chandlerc.com/D2250



More information about the llvm-commits mailing list