[llvm] r195129 - Fix assembly operands for the SSE2 cvtsd2ss instruction.

Cameron McInally cameron.mcinally at nyu.edu
Thu Nov 21 08:33:38 PST 2013


Hey Chad,

On Thu, Nov 21, 2013 at 10:19 AM, Chad Rosier <mcrosier at codeaurora.org> wrote:
> Hi Cameron,
> Did this test case fail prior to your change?
>
> You're test case produces a single cvtsd2ss instruction, but you have two
> FileCheck directives.  My thought is that the first CHECK is consuming the
> cvtsd2ss token and thus the CHECK-NOT will always pass because there's no
> second cvtsd2ss to match.  Perhaps you could create two tests one to check
> for what you expect and a second to check for what you don't expect?
>
> I'm not a FileCheck expert, but hopefully that makes sense. :)
>

Yup, I tested my test before committing. :)

Perhaps this is entirely fortuitous though. I am under the impression
that CHECK-NEXT is required to enforce an ordering, but that might not
be so. Maybe someone more familiar with FileCheck can chime in.

-Cameron



More information about the llvm-commits mailing list