[PATCH] R600/SI: Implement add i64 support

Tom Stellard tom at stellard.net
Mon Nov 18 11:16:23 PST 2013


On Fri, Nov 15, 2013 at 03:43:57PM -0800, Matt Arsenault wrote:
> 
> On Nov 15, 2013, at 10:19 AM, Tom Stellard <tom at stellard.net> wrote:
> 
> > Hi Matt,
> > 
> > Overall, these look good, just a few comments.  I want to test these
> > before they are pushed.  I will let you know when I am done with this.
> > 
> > -Tom
> > 
> 
> Merged duplicate SCC/VCC operand patches, updated tests for scalar operations being selected more often and removed getVRegClassID
> 
> 

Hi Matt,

I just finished testing these patches.  They uncovered two bugs in
the SIFixSGPRCopies pass, but I have just pushed fixes for these.  Patch
10 adds an unnecessary whitespace change in SIInstrInfo.h, but with that
fixed, this entire series is:

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

Feel free to push them whenever you want.

-Tom



More information about the llvm-commits mailing list