[PATCH][X86] SSE2 cvtsd2ss instruction expects two operands

Craig Topper craig.topper at gmail.com
Fri Nov 15 17:01:16 PST 2013


LGTM


On Fri, Nov 15, 2013 at 10:36 AM, Cameron McInally <cameron.mcinally at nyu.edu
> wrote:

> Hey Craig,
>
> On Fri, Nov 15, 2013 at 12:21 PM, Craig Topper <craig.topper at gmail.com>
> wrote:
> > I don't think this patch was ever committed. Can you confirm and commit
> if
> > it wasn't?
> >
> >
> > On Tue, Oct 15, 2013 at 12:28 PM, Cameron McInally
> > <cameron.mcinally at nyu.edu> wrote:
> >>
> >> Hey guys,
> >>
> >> Here is a small patch to fix the Int_CVTSD2SS patterns. This SSE2
> >> instruction expects two operands, not three.
> >>
> >> Also, I do not have commit access.
> >>
> >> Thanks,
> >> Cameron
> >
> >
> >
> >
> > --
> > ~Craig
>
> Sorry, this fell off my radar. I've attached the original patch, with
> Quentin's suggested test case, for review. I have not had time to
> investigate the CHECK mechanism further.
>
> -Cameron
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131115/87d828a8/attachment.html>


More information about the llvm-commits mailing list