[lld][PATCH] Fix typo in the File::processTargetsTable() routine

[Shankar Easwaran]

Hi Simon,

I would write a yaml file containing all these atoms and have less 
defined atoms and more absolute atoms.

The defined atom would have references to all the absolute atoms.

Infact, I tried to do that for a few minutes and wanted to check if it 
fails something. It wouldnt :(

Something along this direction would make the test fail, I assume.

Hope this helps.

Thanks

Shankar Easwaran

On 11/4/2013 1:39 PM, Simon Atanasyan wrote:
> Thanks for review. I will commit the patch right now and add the test
> a bit later. I need a time to figure out how to check this bug.
>
> On Mon, Nov 4, 2013 at 10:42 PM, Shankar Easwaran
> <shankare at codeaurora.org> wrote:
>> LGTM. A test that uncovers could be useful, since we do have
>> the RoundTrip passes that could be used to verify the change.
>>
>> On 11/4/2013 12:05 PM, Simon Atanasyan wrote:
>> It looks like the File::processTargetsTable() routine has a typo in
>> the expression calculates an absolute atom offset. It uses slIndex
>> instead of abIndex. But I am not an expert in lld code so I am not
>> sure for 100%.
>>
>> Could you please to take a look at the patch. If it is OK I will
>> commit the patch.
> Regards,
> Simon
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation