[lld][PATCH] Fix typo in the File::processTargetsTable() routine

Simon Atanasyan simon at atanasyan.com
Mon Nov 4 11:39:36 PST 2013


Thanks for review. I will commit the patch right now and add the test
a bit later. I need a time to figure out how to check this bug.

On Mon, Nov 4, 2013 at 10:42 PM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
> LGTM. A test that uncovers could be useful, since we do have
> the RoundTrip passes that could be used to verify the change.
>
> On 11/4/2013 12:05 PM, Simon Atanasyan wrote:
> It looks like the File::processTargetsTable() routine has a typo in
> the expression calculates an absolute atom offset. It uses slIndex
> instead of abIndex. But I am not an expert in lld code so I am not
> sure for 100%.
>
> Could you please to take a look at the patch. If it is OK I will
> commit the patch.

Regards,
Simon



More information about the llvm-commits mailing list