[patch] Convert BitcodeReader to use error_code

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Nov 1 13:53:09 PDT 2013


> Awesome!
>
> I think you should make the error codes a little more coarse grained.  There isn't very much actionable based on the error codes anyway, so you can probably limit them down to 5 or 6 different codes.  Anyone trying to debug a bitcode reading problem will have to step through the code to figure out what is really wrong anyway.

The attached patch brings it down to 19. Is that OK? If not, any
preference as to which ones should be merged?

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 94989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131101/93c4327d/attachment.bin>


More information about the llvm-commits mailing list