[patch] Convert BitcodeReader to use error_code
Chris Lattner
clattner at apple.com
Thu Oct 31 19:38:55 PDT 2013
On Oct 31, 2013, at 7:28 PM, Rafael EspĂndola <rafael.espindola at gmail.com> wrote:
> In order to use create a ObjectFile implementation for IR objects I
> need to convert the error handling of IR reading to that of ObjectFile
> (error_code).
>
> The attached patch converts BitcodeReader.
Awesome!
I think you should make the error codes a little more coarse grained. There isn't very much actionable based on the error codes anyway, so you can probably limit them down to 5 or 6 different codes. Anyone trying to debug a bitcode reading problem will have to step through the code to figure out what is really wrong anyway.
Thanks for working on this Rafael!
-Chris
More information about the llvm-commits
mailing list