[PATCH] [PECOFF][ELF][Darwin] Changes to fix some real issues in code

[Shankar Easwaran]

On 10/28/2013 1:26 PM, Rui Ueyama wrote:
> Ah, there was a misunderstanding there. What I meant was that patch file
> attachments, as opposed to setting up a new git repository, is of course OK.
Ah.
> r193478 and r193477 are LGTM. They would fix the tests failing with
> RoundTrip tests. r193479 is however wouldn't.
These changes did fix some more of the failures.

For example I couldnt figure out where the ImportDirectoryAtom gets 
added to the PassManager file.

For example, the lld Pass calls createImportDirectory, which adds to the 
list of Import Directories.

I looked at the YAML files too before adding those changes, and they 
didnt appear in the YAML file.

I think you forgot to answer the question, are you ok with submitting 
the RoundTrip{YAML, Native} changes with the changes in the Driver 
removed, this would make all the tests pass and we can continue to 
figure out why those tests would fail, by enabling the RoundTrip code.

Once all the test results are fine, we could enable it completely.

Looks like the IdataPass for COFF is really very complex!

Thanks

Shankar Easwaran