[PATCH] [PECOFF][ELF][Darwin] Changes to fix some real issues in code

[Rui Ueyama]

Ah, there was a misunderstanding there. What I meant was that patch file
attachments, as opposed to setting up a new git repository, is of course OK.

r193478 and r193477 are LGTM. They would fix the tests failing with
RoundTrip tests. r193479 is however wouldn't. These IdataAtoms has already
been added to the file, so re-adding them wouldn't fix the breakage, I
think. It might cause another issue, so let me roll that commit back.

On Mon, Oct 28, 2013 at 7:22 AM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   <---------------snip------------>
>
>   Thank you for sending the patches, but I'm still having trouble applying
> them. What I did was syncing to r193302 and then run git am. Patch 0004
> failed. I also synced to HEAD and run git am. The patch were cleanly
> applied, but it couldn't compile. If you are familiar with git workflow and
> have an externally-accessible git repository, you might want to create a
> branch for it and push it to the external repository, so that I can pull
> and test it locally. That might be convenient. Patches are of course OK,
> though.
>                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   <---------------/snip-------------->
>
>   Can you please refer to this mail snip. I was under the impression that
> the patch is ok from the mail as well as there were no test failures. If
> you think that the changes are not fine, please do go ahead and revert the
> changes (or) could you let me know about the changes so that I can
> understand the issue and fix it in the later patches.
>
>   As for the tests, the tests do pass, am confused now. Are there any
> silent failures that you are seeing when the patches are applied.
>
>   As for the main RoundTripPatch, let me know I could delete the lines
> from the driver that adds the RoundTrip Passes. This would make all of the
> current tests pass too. It might be easier to fix the git issues that you
> are seeing with the patches that I have kept sending to you. Let me know if
> you agree ?


Can you send us the RoundTrip tests patch? I tried to resurrect the commit
but it failed because of the changes that were made after r193362. I'd
think we need a new patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131028/c323d691/attachment.html>