[llvm] r193251 - Use address-taken to disambiguate global variable and indirect memops.

[Chris Lattner]

On Oct 26, 2013, at 5:40 PM, Chandler Carruth <chandlerc at google.com> wrote:

> > > URL: http://llvm.org/viewvc/llvm-project?rev=193251&view=rev
> > > Log:
> > > Use address-taken to disambiguate global variable and indirect memops.
> > >
> > > Major steps include:
> > > 1). introduces a not-addr-taken bit-field in GlobalVariable
> > > 2). GlobalOpt pass sets "not-address-taken" if it proves a global varirable
> > >    dosen't have its address taken.
> > > 3). AA use this info for disambiguation.
> >
> > Shuxin please revert this immediately.
> >
> > This is a major IR change.  Please propose IR changes (e.g. new bits in key datatypes) on llvmdev before making any changes like this.  This is completely inappropriate for post-commit review.
> 
> He actually asked for precommit review and had a response on that thread on Tuesday. The response wasn't an LGTM tho and in no way did it look like it was done being reviewed.
> 
> 

Yep, and it wasn't on llvmdev, and it wasn't clear that this was an IR change.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131026/5dc4deff/attachment.html>