<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 26, 2013, at 5:40 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p dir="ltr" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">> > URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=193251&view=rev">http://llvm.org/viewvc/llvm-project?rev=193251&view=rev</a><br>> > Log:<br>> > Use address-taken to disambiguate global variable and indirect memops.<br>> ><br>> > Major steps include:<br>> > 1). introduces a not-addr-taken bit-field in GlobalVariable<br>> > 2). GlobalOpt pass sets "not-address-taken" if it proves a global varirable<br>> > dosen't have its address taken.<br>> > 3). AA use this info for disambiguation.<br>><br>> Shuxin please revert this immediately.<br>><br>> This is a major IR change. Please propose IR changes (e.g. new bits in key datatypes) on llvmdev before making any changes like this. This is completely inappropriate for post-commit review.</p><p dir="ltr" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">He actually asked for precommit review and had a response on that thread on Tuesday. The response wasn't an LGTM tho and in no way did it look like it was done being reviewed.</p><div><br></div></blockquote><br></div><div>Yep, and it wasn't on llvmdev, and it wasn't clear that this was an IR change.</div><div><br></div><div>-Chris</div></body></html>