[PATCH] [ARM] Implement eabi_attribute, cpu, and fpu directives.
Logan Chien
tzuhsiang.chien at gmail.com
Sat Oct 26 02:32:12 PDT 2013
================
Comment at: lib/Target/ARM/ARM.td:324
@@ -323,2 +323,3 @@
FeatureT2XtPk, FeatureVFP4,
- FeatureVFPOnlySP, FeatureMClass]>;
+ FeatureVFPOnlySP, FeatureD16,
+ FeatureMClass]>;
----------------
According to ARMv7-M Reference Manual, the ARM floating point extension for ARMv7-M is named as FPV4-SP, which is a single precision only variant of VFPv4-d16. Thus, I think we should add FeatureD16 to this subtarget.
================
Comment at: lib/Target/ARM/ARM.td:312
@@ -311,3 +311,3 @@
FeatureHasRAS, FeatureVFPOnlySP,
- FeatureRClass]>;
+ FeatureD16, FeatureRClass]>;
----------------
For not breaking the existing test cases, I have to add FeatureD16 to cortex-r5 subtarget. Although this is the default behavior of GCC, however, I can't find any document stating cortex-r5 has only d0-d15. Should I change the test case instead?
http://llvm-reviews.chandlerc.com/D1987
More information about the llvm-commits
mailing list