[llvm] r193180 - R600/SI: Fix warning on non-asserts build

[Tom Stellard]

On Tue, Oct 22, 2013 at 11:39:57AM -0700, David Blaikie wrote:
> On Tue, Oct 22, 2013 at 11:31 AM, Tom Stellard <thomas.stellard at amd.com>wrote:
> 
> > Author: tstellar
> > Date: Tue Oct 22 13:31:45 2013
> > New Revision: 193180
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=193180&view=rev
> > Log:
> > R600/SI: Fix warning on non-asserts build
> >
> 
> Generally we prefer to use llvm_unreachable for always-false asserts, and I
> /think/ that would tidy up the warning too.
> 

I replaced this with llvm_unreachable() and there were no buildbot
failures, thanks for the tip.

-Tom

> 
> >
> > Modified:
> >     llvm/trunk/lib/Target/R600/SIInstrInfo.cpp
> >
> > Modified: llvm/trunk/lib/Target/R600/SIInstrInfo.cpp
> > URL:
> > http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/SIInstrInfo.cpp?rev=193180&r1=193179&r2=193180&view=diff
> >
> > ==============================================================================
> > --- llvm/trunk/lib/Target/R600/SIInstrInfo.cpp (original)
> > +++ llvm/trunk/lib/Target/R600/SIInstrInfo.cpp Tue Oct 22 13:31:45 2013
> > @@ -202,6 +202,7 @@ MachineInstr *SIInstrInfo::buildMovInstr
> >                                           unsigned DstReg,
> >                                           unsigned SrcReg) const {
> >    assert(!"Not Implemented");
> > +  return NULL;
> >  }
> >
> >  bool SIInstrInfo::isMov(unsigned Opcode) const {
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits