[llvm] r193180 - R600/SI: Fix warning on non-asserts build

David Blaikie dblaikie at gmail.com
Tue Oct 22 11:39:57 PDT 2013


On Tue, Oct 22, 2013 at 11:31 AM, Tom Stellard <thomas.stellard at amd.com>wrote:

> Author: tstellar
> Date: Tue Oct 22 13:31:45 2013
> New Revision: 193180
>
> URL: http://llvm.org/viewvc/llvm-project?rev=193180&view=rev
> Log:
> R600/SI: Fix warning on non-asserts build
>

Generally we prefer to use llvm_unreachable for always-false asserts, and I
/think/ that would tidy up the warning too.


>
> Modified:
>     llvm/trunk/lib/Target/R600/SIInstrInfo.cpp
>
> Modified: llvm/trunk/lib/Target/R600/SIInstrInfo.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/SIInstrInfo.cpp?rev=193180&r1=193179&r2=193180&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/R600/SIInstrInfo.cpp (original)
> +++ llvm/trunk/lib/Target/R600/SIInstrInfo.cpp Tue Oct 22 13:31:45 2013
> @@ -202,6 +202,7 @@ MachineInstr *SIInstrInfo::buildMovInstr
>                                           unsigned DstReg,
>                                           unsigned SrcReg) const {
>    assert(!"Not Implemented");
> +  return NULL;
>  }
>
>  bool SIInstrInfo::isMov(unsigned Opcode) const {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131022/857f7de2/attachment.html>


More information about the llvm-commits mailing list