[PATCH] [asan] Wipe all poisoned memory in fake stack frames before passing them to LSan

Kostya Serebryany kcc at google.com
Tue Oct 22 02:49:28 PDT 2013



================
Comment at: lib/asan/asan_fake_stack.cc:153
@@ +152,3 @@
+  uptr ptr = begin + sizeof(FakeFrame);
+  CHECK_EQ(0, ptr % 8);
+  CHECK_EQ(0, end % 8);
----------------
Don't use 8, we have SHADOW_GRANULARITY and SHADOW_SCALE macros

================
Comment at: lib/asan/asan_thread.cc:329
@@ +328,3 @@
+    // against garbage pointers contained in reused stack frames.
+    t->fake_stack()->ForEachFakeFrame(&__asan::FakeStack::WipePoisonedCallback,
+                                      0);
----------------
can we have a single callback here? 


http://llvm-reviews.chandlerc.com/D1962



More information about the llvm-commits mailing list