[PATCH] Change llvm-objdump to print (bad) for invalid instructions
Stephen Checkoway
s at pahtak.org
Fri Oct 18 13:28:58 PDT 2013
On Oct 18, 2013, at 4:23 PM, Rafael EspĂndola <rafael.espindola at gmail.com> wrote:
>> My thinking was that a unit test would test out-of-tree targets as well. If their disassemblers were copied from any of the in-tree targets, then they're almost certainly returning 0 bytes for invalid instructions. The unit test was designed to catch that (assuming the SubtargetInfo could be constructed from the architecture name alone).
>>
>> If that's not a concern or it's the wrong way to go about it, I can add tests for each in-tree target.
>
> We normally use unit tests only when the issue is not easily visible
> from one of the existing tools.
Okay. I'll change them to normal tests as soon as I get a chance.
--
Stephen Checkoway
More information about the llvm-commits
mailing list