Erase NDBEUG from all Release targets

Yaron Keren yaron.keren at gmail.com
Wed Oct 16 10:49:14 PDT 2013


Hi Reid,

I don't know how (gmail tabs?) but I never saw your reply, sorry for the
late response.

I'm attaching the same patch against a newer r192756,  please submit this,
I don't have commit rights.

Yaron




2013/9/19 Reid Kleckner <rnk at google.com>

> Yeah, go for it.  Do you need someone to commit it?



On Thu, Sep 19, 2013 at 8:50 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> While patching HandleLLVMOptions, I noticed that NDBEUG is removed only
> from the release compile flags but not from the minimum size release or the
> release with debug info.  With these targets Visual C++ warns about NDEBUG
> being defined and undefined.
>
> The attached patch addresses the issue.
>
> Yaron
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131016/97c35833/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ndebug.diff
Type: application/octet-stream
Size: 1029 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131016/97c35833/attachment.obj>


More information about the llvm-commits mailing list