[PATCH] Fix MCDataAtom never calling remap when adding data.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Oct 16 12:07:15 PDT 2013


r192827. Thanks!

On 16 October 2013 14:45, Stephen Checkoway <s at pahtak.org> wrote:
>
> On Oct 16, 2013, at 2:33 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>
>>> I will commit the original one and review this one in a sec.
>>
>> I committed the patch as r192823. On the new one, I think my only
>> comment is the same as Jim Grosbach's in the other patch. If we know
>> the size of the instruction, we should skip that, not just one byte.
>
>
> Great, thanks!
>
> Here's a new patch that uses the size returned by getInstruction() with an assert that it's nonzero.
>
> --
> Stephen Checkoway
>
>
>
>
>
>




More information about the llvm-commits mailing list