[PATCH] Fix MCDataAtom never calling remap when adding data.

Stephen Checkoway s at pahtak.org
Wed Oct 16 11:45:26 PDT 2013


On Oct 16, 2013, at 2:33 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

>> I will commit the original one and review this one in a sec.
> 
> I committed the patch as r192823. On the new one, I think my only
> comment is the same as Jim Grosbach's in the other patch. If we know
> the size of the instruction, we should skip that, not just one byte.


Great, thanks!

Here's a new patch that uses the size returned by getInstruction() with an assert that it's nonzero.

-- 
Stephen Checkoway



-------------- next part --------------
A non-text attachment was scrubbed...
Name: MCObjectDisassembler-data-in-text.diff
Type: application/octet-stream
Size: 1887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131016/b453a711/attachment.obj>
-------------- next part --------------



More information about the llvm-commits mailing list