[PATCH] Fixed a bug with section names containing special characters.

[Richard Mitton]

No worries,

committed in r191932 with changes as requested.

Richard Mitton
richard at codersnotes.com

On 10/03/2013 02:55 PM, Eric Christopher wrote:
>    LGTM with the changes requested. Sorry for the delay.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1152
> @@ -1134,3 +1151,3 @@
>       if (Section) {
> -      Sym = Asm->GetTempSymbol(Section->getLabelEndName());
> +      Sym = Asm->GetTempSymbol("debug_end", ID);
>         Asm->OutStreamer.SwitchSection(Section);
> ----------------
> Can you add a comment here that we're not using the section's label end name because it might be unprintable? (Also, I wonder how many other places this happens?)
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:315
> @@ -314,1 +314,3 @@
>   
> +static bool SectionSort(const MCSection *A, const MCSection *B) {
> +    std::string LA = (A ? A->getLabelBeginName() : "");
> ----------------
> Block comment here please.
>
>
> http://llvm-reviews.chandlerc.com/D1790