[PATCH] Fixed a bug with section names containing special characters.

Eric Christopher echristo at gmail.com
Thu Oct 3 14:55:42 PDT 2013


  LGTM with the changes requested. Sorry for the delay.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1152
@@ -1134,3 +1151,3 @@
     if (Section) {
-      Sym = Asm->GetTempSymbol(Section->getLabelEndName());
+      Sym = Asm->GetTempSymbol("debug_end", ID);
       Asm->OutStreamer.SwitchSection(Section);
----------------
Can you add a comment here that we're not using the section's label end name because it might be unprintable? (Also, I wonder how many other places this happens?)

================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:315
@@ -314,1 +314,3 @@
 
+static bool SectionSort(const MCSection *A, const MCSection *B) {
+    std::string LA = (A ? A->getLabelBeginName() : "");
----------------
Block comment here please.


http://llvm-reviews.chandlerc.com/D1790



More information about the llvm-commits mailing list