[PATCH] llvm-objdump: Dump COFF import table if -private-headers option is given.

Rui Ueyama ruiu at google.com
Thu Sep 26 16:21:08 PDT 2013



================
Comment at: include/llvm/Object/COFF.h:298-299
@@ -289,1 +297,4 @@
 
+  import_directory_iterator getImportDirectoryBegin() const;
+  import_directory_iterator getImportDirectoryEnd() const;
+
----------------
Michael Spencer wrote:
> LLVM uses <type>_{begin,end} for these.
Looks like _{begin,end} is used only when the prefix is not in camel case.  We already have two different styles of naming (getSectionRelBegin and begin_symbols, for examples). I don't have a preference on that, so if you prefer one over the others, I'll rename them.


http://llvm-reviews.chandlerc.com/D1719

BRANCH
  readobj

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list