[PATCH] llvm-objdump: Dump COFF import table if -private-headers option is given.

Michael Spencer bigcheesegs at gmail.com
Thu Sep 26 15:25:59 PDT 2013


  lgtm.


================
Comment at: include/llvm/Object/COFF.h:298-299
@@ -289,1 +297,4 @@
 
+  import_directory_iterator getImportDirectoryBegin() const;
+  import_directory_iterator getImportDirectoryEnd() const;
+
----------------
LLVM uses <type>_{begin,end} for these.

================
Comment at: include/llvm/Object/COFF.h:348
@@ +347,3 @@
+private:
+  DataRefImpl ImportDirectoryPimpl;
+  const COFFObjectFile *OwningObject;
----------------
This doesn't need to use the DataRefImpl crazyness as it's a COFF specific interface.


http://llvm-reviews.chandlerc.com/D1719

BRANCH
  readobj

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list