[PATCH] Don't localize globals that may serve as leak checker roots.

[Alexey Samsonov]

On Wed, Sep 25, 2013 at 10:21 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > Don't we care about valgrind's leak detector any more? :)
>
> We do, but I would still put this behind a clang -fsanitize=valgrind
> option that is document to disable optimizations that confuse valgrind
> and for now just adds this metadata.
>

Well, I haven't added isLeakCheckerRoot() function - I think it's already
used in GlobalOpt pass to disable some optimizations that may confuse leak
checkers -
e.g. it doesn't remove global variable that may be a leak checker root and
its value is
never loaded.

That said, if you want the optimization to remain, I can change the patch
to make sure
we disable it only if ASan is turned on (that would be a bit more
complicated).


>
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130925/aa621106/attachment.html>