<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Wed, Sep 25, 2013 at 10:21 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">> Don't we care about valgrind's leak detector any more? :)<br>

<br>
</div>We do, but I would still put this behind a clang -fsanitize=valgrind<br>
option that is document to disable optimizations that confuse valgrind<br>
and for now just adds this metadata.<br></blockquote><div><br></div><div>Well, I haven't added <span style="font-family:arial,sans-serif;font-size:13px">isLeakCheckerRoot() function - I think it's already</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">used in GlobalOpt pass to disable some optimizations that may confuse leak checkers -</span></div><div><span style="font-family:arial,sans-serif;font-size:13px">e.g. it doesn't remove global variable that may be a leak checker root and its value is</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">never loaded.</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">That said, if you want the optimization to remain, I can change the patch to make sure</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">we disable it only if ASan is turned on (that would be a bit more complicated).</span></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div class=""><div class="h5"><br>
Cheers,<br>
Rafael<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>