[lld] r191317 - [PECOFF] Ignore /verbose and /wx (warnings as errors) options.

[Rui Ueyama]

These are the flags that the build system usually passes to the linker. I'm
writing a real implementation if it's easy to do so, or just add a stub if
it not. The aim is to make the linker to work with the build system.

It should be obvious which flags are not implemented; they are listed at
the end of WinLinkOptions.td. All the options below "The flags below do
nothing. They are defined only for link.exe compatibility." comment are
no-op options.


On Tue, Sep 24, 2013 at 10:54 AM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> Hi Ruiu,
>
> Whats the point of adding all these options that are being ignored ? Is
> this only for testing ?
>
> It would be hard to determine how many of them are implemented.
>
> Thanks
>
> Shankar Easwaran
>
>
> On 9/24/2013 12:44 PM, Rui Ueyama wrote:
>
>> Author: ruiu
>> Date: Tue Sep 24 12:44:39 2013
>> New Revision: 191317
>>
>> URL: http://llvm.org/viewvc/llvm-**project?rev=191317&view=rev<http://llvm.org/viewvc/llvm-project?rev=191317&view=rev>
>> Log:
>> [PECOFF] Ignore /verbose and /wx (warnings as errors) options.
>>
>> Modified:
>>      lld/trunk/lib/Driver/**WinLinkOptions.td
>>      lld/trunk/unittests/**DriverTests/WinLinkDriverTest.**cpp
>>
>> Modified: lld/trunk/lib/Driver/**WinLinkOptions.td
>> URL: http://llvm.org/viewvc/llvm-**project/lld/trunk/lib/Driver/**
>> WinLinkOptions.td?rev=191317&**r1=191316&r2=191317&view=diff<http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkOptions.td?rev=191317&r1=191316&r2=191317&view=diff>
>> ==============================**==============================**
>> ==================
>> --- lld/trunk/lib/Driver/**WinLinkOptions.td (original)
>> +++ lld/trunk/lib/Driver/**WinLinkOptions.td Tue Sep 24 12:44:39 2013
>> @@ -70,14 +70,23 @@ def DASH_DASH : Option<["--"], "", KIND_
>>   // The flags below do nothing. They are defined only for link.exe
>> compatibility.
>>   //
>>   -class Q<string name> : Joined<["/", "-", "-?"], name#":">;
>> +class QF<string name> : Joined<["/", "-", "-?"], name#":">;
>> +
>> +multiclass QB<string name> {
>> +  def "" : F<name>;
>> +  def _no : F<name#":no">;
>> +}
>>   -def nologo : F<"nologo">;
>>   def incremental : F<"incremental">;
>>   def no_incremental : F<"incremental:no">;
>> +def nologo : F<"nologo">;
>> +def verbose : F<"verbose">;
>> +
>> +def delay : QF<"delay">;
>> +def delayload : QF<"delayload">;
>> +def errorreport : QF<"errorreport">;
>> +def pdb : QF<"pdb">;
>> +def pdbaltpath : QF<"pdbaltpath">;
>> +def verbose_all : QF<"verbose">;
>>   -def pdb : Q<"pdb">;
>> -def pdbaltpath : Q<"pdbaltpath">;
>> -def errorreport : Q<"errorreport">;
>> -def delay : Q<"delay">;
>> -def delayload : Q<"delayload">;
>> +defm wx : QB<"wx">;
>>
>> Modified: lld/trunk/unittests/**DriverTests/WinLinkDriverTest.**cpp
>> URL: http://llvm.org/viewvc/llvm-**project/lld/trunk/unittests/**
>> DriverTests/WinLinkDriverTest.**cpp?rev=191317&r1=191316&r2=**
>> 191317&view=diff<http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=191317&r1=191316&r2=191317&view=diff>
>> ==============================**==============================**
>> ==================
>> --- lld/trunk/unittests/**DriverTests/WinLinkDriverTest.**cpp (original)
>> +++ lld/trunk/unittests/**DriverTests/WinLinkDriverTest.**cpp Tue Sep 24
>> 12:44:39 2013
>> @@ -377,7 +377,8 @@ TEST_F(WinLinkParserTest, Ignore) {
>>     EXPECT_FALSE(parse("link.exe", "/nologo", "/errorreport:prompt",
>>                        "/incremental", "/incremental:no", "/delay:unload",
>>                        "/delayload:user32", "/pdb:foo", "/pdbaltpath:bar",
>> -                     "a.obj", nullptr));
>> +                     "/verbose", "/verbose:icf", "/wx", "/wx:no",
>> "a.obj",
>> +                     nullptr));
>>     EXPECT_EQ("", errorMessage());
>>     EXPECT_EQ(1, inputFileCount());
>>     EXPECT_EQ("a.obj", inputFile(0));
>>
>>
>> ______________________________**_________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>>
>>
>>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130924/f641eac9/attachment.html>