<div dir="ltr">These are the flags that the build system usually passes to the linker. I'm writing a real implementation if it's easy to do so, or just add a stub if it not. The aim is to make the linker to work with the build system.<div>
<br></div><div>It should be obvious which flags are not implemented; they are listed at the end of WinLinkOptions.td. All the options below "The flags below do nothing. They are defined only for link.exe compatibility." comment are no-op options.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 24, 2013 at 10:54 AM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ruiu,<br>
<br>
Whats the point of adding all these options that are being ignored ? Is this only for testing ?<br>
<br>
It would be hard to determine how many of them are implemented.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<div><div><br>
<br>
On 9/24/2013 12:44 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Tue Sep 24 12:44:39 2013<br>
New Revision: 191317<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191317&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=191317&view=rev</a><br>
Log:<br>
[PECOFF] Ignore /verbose and /wx (warnings as errors) options.<br>
<br>
Modified:<br>
lld/trunk/lib/Driver/<u></u>WinLinkOptions.td<br>
lld/trunk/unittests/<u></u>DriverTests/WinLinkDriverTest.<u></u>cpp<br>
<br>
Modified: lld/trunk/lib/Driver/<u></u>WinLinkOptions.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkOptions.td?rev=191317&r1=191316&r2=191317&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/Driver/<u></u>WinLinkOptions.td?rev=191317&<u></u>r1=191316&r2=191317&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/Driver/<u></u>WinLinkOptions.td (original)<br>
+++ lld/trunk/lib/Driver/<u></u>WinLinkOptions.td Tue Sep 24 12:44:39 2013<br>
@@ -70,14 +70,23 @@ def DASH_DASH : Option<["--"], "", KIND_<br>
// The flags below do nothing. They are defined only for link.exe compatibility.<br>
//<br>
-class Q<string name> : Joined<["/", "-", "-?"], name#":">;<br>
+class QF<string name> : Joined<["/", "-", "-?"], name#":">;<br>
+<br>
+multiclass QB<string name> {<br>
+ def "" : F<name>;<br>
+ def _no : F<name#":no">;<br>
+}<br>
-def nologo : F<"nologo">;<br>
def incremental : F<"incremental">;<br>
def no_incremental : F<"incremental:no">;<br>
+def nologo : F<"nologo">;<br>
+def verbose : F<"verbose">;<br>
+<br>
+def delay : QF<"delay">;<br>
+def delayload : QF<"delayload">;<br>
+def errorreport : QF<"errorreport">;<br>
+def pdb : QF<"pdb">;<br>
+def pdbaltpath : QF<"pdbaltpath">;<br>
+def verbose_all : QF<"verbose">;<br>
-def pdb : Q<"pdb">;<br>
-def pdbaltpath : Q<"pdbaltpath">;<br>
-def errorreport : Q<"errorreport">;<br>
-def delay : Q<"delay">;<br>
-def delayload : Q<"delayload">;<br>
+defm wx : QB<"wx">;<br>
<br>
Modified: lld/trunk/unittests/<u></u>DriverTests/WinLinkDriverTest.<u></u>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=191317&r1=191316&r2=191317&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/unittests/<u></u>DriverTests/WinLinkDriverTest.<u></u>cpp?rev=191317&r1=191316&r2=<u></u>191317&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/unittests/<u></u>DriverTests/WinLinkDriverTest.<u></u>cpp (original)<br>
+++ lld/trunk/unittests/<u></u>DriverTests/WinLinkDriverTest.<u></u>cpp Tue Sep 24 12:44:39 2013<br>
@@ -377,7 +377,8 @@ TEST_F(WinLinkParserTest, Ignore) {<br>
EXPECT_FALSE(parse("link.exe", "/nologo", "/errorreport:prompt",<br>
"/incremental", "/incremental:no", "/delay:unload",<br>
"/delayload:user32", "/pdb:foo", "/pdbaltpath:bar",<br>
- "a.obj", nullptr));<br>
+ "/verbose", "/verbose:icf", "/wx", "/wx:no", "a.obj",<br>
+ nullptr));<br>
EXPECT_EQ("", errorMessage());<br>
EXPECT_EQ(1, inputFileCount());<br>
EXPECT_EQ("a.obj", inputFile(0));<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div></div>