[Patch] X86 horizontal vector reduction cost model

[Eric Christopher]

+    { ISD::ADD,   MVT::v4i32,   3 },      // The raw data is 2.8,
+    { ISD::ADD,   MVT::v4i64,   3 },      // Use Data from avx

These comments seem next to useless? Not sure where you've grabbed the
data from or what raw data means.

Odd formatting nit:

+    { ISD::FADD,   MVT::v8f32,   4 },     // Use Data from avx
+    { ISD::ADD,   MVT::v2i64,   1 },      // The raw data is 1.5

If you're going to use multiple spaces after a , then why not line up
the columns? Otherwise you may as well make it a single space :)

-eric


On Wed, Sep 18, 2013 at 1:50 PM, yijiang <yjiang at apple.com> wrote:
> Hi Arnolds et al.
>
> This patch is to polish horizontal vector reduction cost model for X86 target. Please help to review it. Thank you.
>
>
>
> -Yi
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>