[llvm] r190269 - Debug Info: pass in DIScope instead of DIDescriptor in createMemberType.

[David Blaikie]

On Sat, Sep 7, 2013 at 9:08 PM, Manman Ren <manman.ren at gmail.com> wrote:

> Author: mren
> Date: Sat Sep  7 23:07:59 2013
> New Revision: 190269
>
> URL: http://llvm.org/viewvc/llvm-project?rev=190269&view=rev
> Log:
> Debug Info: pass in DIScope instead of DIDescriptor in createMemberType.
>

presumably members can only be scoped within DICompositeTypes, yes? So we
could make it even more narrow. (though I don't suppose you need to
immediately, for your own purposes)


>
> Improve readability. No functionality change.
>
> Modified:
>     llvm/trunk/include/llvm/DIBuilder.h
>     llvm/trunk/lib/IR/DIBuilder.cpp
>
> Modified: llvm/trunk/include/llvm/DIBuilder.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DIBuilder.h?rev=190269&r1=190268&r2=190269&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/DIBuilder.h (original)
> +++ llvm/trunk/include/llvm/DIBuilder.h Sat Sep  7 23:07:59 2013
> @@ -191,7 +191,7 @@ namespace llvm {
>      /// @param Flags        Flags to encode member attribute, e.g. private
>      /// @param Ty           Parent type.
>      DIDerivedType
> -    createMemberType(DIDescriptor Scope, StringRef Name, DIFile File,
> +    createMemberType(DIScope Scope, StringRef Name, DIFile File,
>                       unsigned LineNo, uint64_t SizeInBits, uint64_t
> AlignInBits,
>                       uint64_t OffsetInBits, unsigned Flags, DIType Ty);
>
>
> Modified: llvm/trunk/lib/IR/DIBuilder.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=190269&r1=190268&r2=190269&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/IR/DIBuilder.cpp (original)
> +++ llvm/trunk/lib/IR/DIBuilder.cpp Sat Sep  7 23:07:59 2013
> @@ -410,7 +410,7 @@ DIDerivedType DIBuilder::createInheritan
>
>  /// createMemberType - Create debugging information entry for a member.
>  DIDerivedType DIBuilder::createMemberType(
> -    DIDescriptor Scope, StringRef Name, DIFile File, unsigned LineNumber,
> +    DIScope Scope, StringRef Name, DIFile File, unsigned LineNumber,
>      uint64_t SizeInBits, uint64_t AlignInBits, uint64_t OffsetInBits,
>      unsigned Flags, DIType Ty) {
>    // TAG_member is encoded in DIDerivedType format.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130907/2c35d85b/attachment.html>