<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Sep 7, 2013 at 9:08 PM, Manman Ren <span dir="ltr"><<a href="mailto:manman.ren@gmail.com" target="_blank">manman.ren@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mren<br>
Date: Sat Sep 7 23:07:59 2013<br>
New Revision: 190269<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190269&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190269&view=rev</a><br>
Log:<br>
Debug Info: pass in DIScope instead of DIDescriptor in createMemberType.<br></blockquote><div><br></div><div>presumably members can only be scoped within DICompositeTypes, yes? So we could make it even more narrow. (though I don't suppose you need to immediately, for your own purposes)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Improve readability. No functionality change.<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/DIBuilder.h<br>
llvm/trunk/lib/IR/DIBuilder.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/DIBuilder.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DIBuilder.h?rev=190269&r1=190268&r2=190269&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DIBuilder.h?rev=190269&r1=190268&r2=190269&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DIBuilder.h (original)<br>
+++ llvm/trunk/include/llvm/DIBuilder.h Sat Sep 7 23:07:59 2013<br>
@@ -191,7 +191,7 @@ namespace llvm {<br>
/// @param Flags Flags to encode member attribute, e.g. private<br>
/// @param Ty Parent type.<br>
DIDerivedType<br>
- createMemberType(DIDescriptor Scope, StringRef Name, DIFile File,<br>
+ createMemberType(DIScope Scope, StringRef Name, DIFile File,<br>
unsigned LineNo, uint64_t SizeInBits, uint64_t AlignInBits,<br>
uint64_t OffsetInBits, unsigned Flags, DIType Ty);<br>
<br>
<br>
Modified: llvm/trunk/lib/IR/DIBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=190269&r1=190268&r2=190269&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=190269&r1=190268&r2=190269&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/IR/DIBuilder.cpp (original)<br>
+++ llvm/trunk/lib/IR/DIBuilder.cpp Sat Sep 7 23:07:59 2013<br>
@@ -410,7 +410,7 @@ DIDerivedType DIBuilder::createInheritan<br>
<br>
/// createMemberType - Create debugging information entry for a member.<br>
DIDerivedType DIBuilder::createMemberType(<br>
- DIDescriptor Scope, StringRef Name, DIFile File, unsigned LineNumber,<br>
+ DIScope Scope, StringRef Name, DIFile File, unsigned LineNumber,<br>
uint64_t SizeInBits, uint64_t AlignInBits, uint64_t OffsetInBits,<br>
unsigned Flags, DIType Ty) {<br>
// TAG_member is encoded in DIDerivedType format.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>